Commits on Source (82)
-
Danial Behzadi authored49e525c9
-
Kukuh Syafaat authoredda5e10d0
-
Марко Костић authoredae235944
-
Zurab Kargareteli authoredab642749
-
Hugo Carvalho authored68bc4a6d
-
gogo authored6820a727
-
Aleksandr Melman authoredc6e0da5f
-
Jordi Mas authored5ee4341f
-
Piotr Drąg authored1c2e3207
-
Sam Hewitt authored
- fixes #5742 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2427>
d7ca1eb7 -
Asier Sarasua Garmendia authored7485481d
-
Luming Zh authored0bd030f7
-
Daniel van Vugt authored
This prevents _sync() being called after actor destruction (since actor destruction became more reliable in mutter@3d94c7cc) and so eliminates this shutdown error: ``` (gnome-shell:35197): Gjs-CRITICAL **: 16:31:02.769: Object .Gjs_ui_calendar_Placeholder (0x559ed6e547e0), has been already disposed — impossible to set any property on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs. == Stack trace for context 0x559ed6022310 == #0 559ed783c5a8 i resource:///org/gnome/shell/ui/calendar.js:1012 (31955be5fc90 @ 148) #1 7ffef8f38230 b self-hosted:1178 (32af8f6b0c40 @ 454) #2 559ed783c518 i resource:///org/gnome/shell/ui/popupMenu.js:806 (31955be18ce0 @ 52) #3 559ed783c488 i resource:///org/gnome/shell/ui/popupMenu.js:954 (31955be190b0 @ 168) #4 559ed783c3f8 i resource:///org/gnome/shell/ui/panelMenu.js:189 (31955be88150 @ 41) #5 7ffef8f3de60 b self-hosted:1178 (32af8f6b0c40 @ 423) ``` Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2429>
4f3b1c51 -
Clerie Riese authored
NetworkManager can check if a network interface has "internet access" by invoking a HTTP request. The URI used for connectivity checking in NetworkManager can be configured manually in NetworkManager.conf: [connectivity] uri=http://portal-check.exmaple.com/nm-check.txt Portal Helper provides an argument to pass the URI that should be opened. If this argument is empty it uses http://nmcheck.gnome.org as a fallback. Pass the URI configured in NetworkManager to Portal Helper instead of an empty string. Fixes #1313 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2228>
2d6b2135 -
Yosef Or Boczko authorede8cb1686
-
Jordi Mas authored9f8b2213
-
Jonas Ådahl authored
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2434>
0b45bc87 -
Florian Müllner authored
Since we put the actual slider into a bin to get a proper focus indication, the slider isn't focused anymore and its accessible object is therefore invisible to the screen reader. Fix this by passing the slider's accessible object to the actor that takes the focus. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2431>
b7d738df -
Florian Müllner authored
We've used find-location since the indicator was added, however the icon theme got a more appropriate location-services-active icon a while ago. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5755 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2430>
8945e256 -
Carlos Garnacho authored
Update these to the current mockups. Since there is now the extended layout for terminals in the OSK, the downwards looking arrow we used for the "hide OSK" action is visually too similar to the "cursor down" key nearby. Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5762 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2433>
712fd3ce -
gogo authored8de67c7a
-
Fran Dieguez authored82b51e64
-
Emin Tufan Çetin authored3fbf41ea
-
Florian Müllner authored
The quick settings code was first developed in an extension, which meant it made sense to maintain compatibility with GNOME 42 and not use the new :icon-name convenience property. There is no good for sticking with that for GNOME 43 as well. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2439>
e2cd6616 -
Florian Müllner authored
When we aren't showing the power toggle (read: on systems without a battery), all items in the top are located on one side. Address this by "moving" the spacer between "Settings" and "Screen Lock" in that case to balance items a bit better. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2439>
6050229a -
Florian Müllner authored
It is currently not possible to bring up the screenshot UI while locked, but that is about to change. We still don't want screencasts in that case, because they are much easier to abuse for filling up someone else's disk. That restriction is enforced by inhibiting remote access in the backend, so trying to create a screencast session will fail anyway. Still, not offering an action that is unavailable is better than having it fail silently, so do exactly that. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2439>
aa7bc4cf -
Florian Müllner authored
We currently don't take the session mode's `hasWindows` property into account when deciding whether window screenshots should be allowed. Right now that doesn't matter in practice, because all the ways to bring up the screenshot UI are blocked in those modes anyway. This is about to change though, so take the property into account to prevent an information leak. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2439>
f9135cdc -
Florian Müllner authored
We will expose the screenshot UI from quick settings, including on the lock screen. It would be odd to restrict keyboard shortcuts more than the more accessible UI, so relax the modes for the screenshot-ui and screen-screenshot shortcuts. We still disable all screenshot shortcuts on the login screen, as users don't have an obvious way to retrieve the screenshot files. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2439>
6db6db8a -
Florian Müllner authored
We got a shiny new screenshot UI last cycle, but only relatively obscure ways of launching it: Keyboard shortcut or overview search. The new quick settings provides us with a natural place to expose the functionality more prominently, and at the same time reduce the emptiness of the top row, in particular on systems without a battery and when locked. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2439>
1e9749a7 -
Georges Basile Stavracas Neto authored
This reverts commit 01e43969. As per design feedback [1]. [1] https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2335#note_1525991 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2442>
82b1a36b -
Georges Basile Stavracas Neto authored
This reverts commit 341cad76. Related: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5738 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2442>
279ba0f4 -
Georges Basile Stavracas Neto authored
So that it can handle the now always visible arrows without downscaling the icons. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2442>
2f3256fe -
Sam Hewitt authored
- improves hover style; fixes #5765 - adds missing high contrast borders - bumps colors for visibility Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2441>
b9359f4f -
Carlos Garnacho authored
During development of the OSK updates, this._modifiers turned from an array into a Set(), but this location missed switching from length() to size() to get the cardinality of the contained values. As a result, the OSK misbehaved and resorted for key event forwarding for impossible keyvals, instead of handing them directly to the IM. Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5766 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2445>
62259017 -
Daniel Mustieles authored210cd0f7
-
Nart Tlisha authored9a94eb51
-
Marek Černocký authored8fb20171
-
Marek Černocký authored4a0cfbc5
-
gogo authoredf50110e8
-
Dmitrii Naidolinskii authored
When saving a screenshot, the GdkPixbuf created would be left with a dangling reference after saving to disk (either leaked on errors, or via an extra reference on success). Always unref the pixbuf so it's either destroyed on error or there is a single reference fully transferred to the caller of the function. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5501 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2449>
f5754adb -
msizanoen1 authored
This reverts commit f5754adb in accordance with https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2449#note_1539435. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2452>
2d589ec3 -
Sebastian Keller authored
The object the SignalTracker belongs to is stored in a map managed by the SignalManager which keeps a reference to that object. This map is never destroyed nor is any entry ever removed. This leads to all objects that ever had SignalTrackers used on them being kept alive even after all references outside of the SignalTracker are long gone. This then also extends to other objects which are leaked indirectly through reference chains from these objects. And if some of those objects are GObjects, this will prevent them from being finalized, leaking further resources. A StWidget for example will not release its shadow textures. Fix this by using a WeakMap in SignalManager. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5807 Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5796 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2450>
085102be -
Florian Müllner authored
If a device has multiple connections set up, then at most one of those can be active at a time, which is why they are presented as radio items. In contrast, VPN connections are not mutually exclusive, each can be turned on or off independently. Setting :radio-mode on them currently means that VPN connections can be activated, but never disabled. So instead of abusing the :radio-mode property to give VPN items the UI we want, use regular items that reflect the desired behavior and explicitly set up the UI the way we want. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2426>
6c56de82 -
Due to !2056 the monitor config is 2 instead of 4 on the desktop. However, the constant `Meta.MonitorSwitchConfigType.UNKNOWN` is fixed to 4, and may cause the initial selection to be out of index thus fail to display the switcher. This replaces the above constant to the actual length of the switcher items. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2451>
137c50b6 -
Florian Müllner authored
Otherwise it shows up as plain "push button". Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2455>
2ed0a61b -
Leônidas Araújo authored582c63c9
-
Florian Müllner authored
grab_screenshot_content() does not follow the usual pattern of ``` task = g_task_new (...); g_task_run_in_thread (task, ...); g_object_unref (task); ``` That means we hold the original reference throughout the operation, and must release it ourselves when done. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5501 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2461>
66ae4c7f -
Milan Crha authored
When a recurring event has deleted a single instance, it's received as an event modification, thus make sure all of the old instances are removed before adding the event to the list of events. Closes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4592 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2328>
a6244e34 -
Florian Müllner authored
StButton already has a :label property, so we should override it instead of shadowing it with a new property of the same name, like we already do for :icon-name. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2462>
646cb41e -
Florian Müllner authored
We get device icons from gnome-volume-control, which itself may get them from pulseaudio. That is, we don't have control over whether icon names are symbolic. As we do want menu items to use symbolic icons, enforce that via CSS instead. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5805 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2456>
d8dc85cc -
Matej Urbančič authoredcbbd9df1
-
Balázs Úr authoredb8835d1e
-
Nathan Follens authored4ad2a2d1
-
Florian Müllner authored
Mutter grew a dependency on colord, so bump the image to pull it in. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2464>
6dc63d3a -
Florian Müllner authored
Commit 9168f605 marked the parameter as nullable, which is in conflict with the precondition check. But given that NULL is valid for the underlying ClutterText (and GtkLabel accepts it as well), there's no strong argument for disallowing NULL, so remove the precondition check. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2465>
329a2863 -
Carlos Garnacho authored
We can figure out the position to render the text without resorting to font sizes that make the whole text element sub-pixel size. As the original labels in the SVG are themed invisible anyway, calculate the button/ring/strip label and configuration UI position from their unchanged size/location. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5415 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2288>
a89d2aed -
Baurzhan Muftakhidinov authored471d9deb
-
Rūdolfs Mazurs authoreda410631b
-
Alan Mortensen authored9131965b
-
Sam Hewitt authored
- reduce overall menu padding - reduce internal padding on submenu - tweak button sizing Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2463>
e07132a6 -
Florian Müllner authored
Client.default_adapter_state is a recent API addition, so update the HAVE_BLUETOOTH check accordingly before depending on it. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2444>
9bda3706 -
Florian Müllner authored
GnomeBluetooth now exposes a more precise state than the binary "adapter fully powerered on/off" property. Expose that on the BtClient object to make it available to the toggle and indicator. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5773 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2444>
d54dc08a -
Florian Müllner authored
Turning bluetooth on or off can be very slow – 10-15 seconds on my system – and we currently don't provide any feedback that something is indeed happening until the state changes at last. Address this by using the `acquiring` icon when the adapter is in a transitioning state. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5773 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2444>
6a23e8ee -
Sebastian Keller authored
This reverts commit 085102be. We need the SignalManager map top be iterable at shutdown for some of the following changes. A WeakMap is not iterable. This revert changes it back to a regular Map, which re-introduces the leaks caused by this. Those will be fixed differently by the two followup commits. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2466>
d57953ad -
Sebastian Keller authored
After the next commit, when some classes, such as PopupMenuManager try to disconnect via a destroy handler, the SignalTracker might have already been destroyed, so trying to get it from the SignalManager will cause it to create a new one, which will then try to connect to the destroy signal of the already destroyed object. This could for example be triggered by changing backgrounds. Fix this by not doing anything in disconnectObject if there is no SignalTracker for that object. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2466>
54ee728a -
Sebastian Keller authored
The object the SignalTracker belongs to is stored in a map managed by the SignalManager which keeps a reference to that object. This map is never destroyed nor is any entry ever removed. This leads to all objects that ever had SignalTrackers used on them being kept alive even after all references outside of the SignalTracker are long gone. This then also extends to other objects which are leaked indirectly through reference chains from these objects. And if some of those objects are GObjects, this will prevent them from being finalized, leaking further resources. A StWidget for example will not release its shadow textures. Fix this by destroying the SignalTracker and removing it from the SignalManager once the last signal it was tracking has been untracked. A WeakMap could have been used as well, but we need the Map to be iterable in some of the following changes. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5807 Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5796 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2466>
91ce5ca9 -
Sebastian Keller authored
Pipewire 0.3.52 via commit a1f33a99 introduced a change that affects how long pipewiresrc holds onto the pw_buffers it dequeued. Before that change the pw_buffer was held until the end of the videoconvert element at the beginning of the pipeline. After that change the pw_buffer was held onto until the filesink at the end of the pipeline. This was starving MetaScreenCastStreamSrc of pw_buffers to record new frames into, resulting in the majority of frames being missed, especially in situations in which the encoder was taking longer. Pipewire 0.3.57 via commit 1ea1d525 will allow queuing the pw_buffer early again via the `always-copy` option. This however is only a workaround until a proper solution is found in either pipewire or gstreamer that does not depend on copying the buffer contents and instead queues the pw_buffer again after videoconvert as prior to a1f33a99. Since it is not clear yet when a proper solution will arrive, this makes use of `always-copy` as a workaround for now and should be reverted once it is no longer needed. Related: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5585 Related: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/2461 Related: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/283 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2436>
d32c0348 -
Changwoo Ryu authored2f08c8f6
-
Florian Müllner authored
Update NEWS.
316dc289 -
Jeremy Bicha authored8c1e4e87
-
Jeremy Bicha authored03bc5d38
-
Jeremy Bicha authoredb7eaad28
-
Jeremy Bicha authored25a78818
-
Jeremy Bicha authored
Update to upstream version '43~rc' with Debian dir 6643cb80a57ca6524036c3d58c7647c15b23a3a8
0286c5a3 -
Jeremy Bicha authored831142dc
-
Jeremy Bicha authored8011b4ec
-
Jeremy Bicha authored
Useful to comply with the intent of Ubuntu's UI Freeze
07d6ce57 -
Jeremy Bicha authored542806aa
-
Jeremy Bicha authored
tagging package gnome-shell version debian/43_rc-1
28c2dc48 -
Jeremy Bicha authored11bb28a7
-
Jeremy Bicha authoredd6ed1150
This diff is collapsed.
debian/gnome-shell-common.postinst
deleted
100644 → 0
debian/gnome-shell-common.preinst
deleted
100644 → 0
debian/gnome-shell-common.prerm
deleted
100644 → 0