Commits on Source (62)
-
António Fernandes authoredcfded2c0
-
Corey Berla authored
The gtk bookmark file stores bookmarks as follows: <encoded file 1 uri> <file 1 label (optional)> <encoded file 2 uri> <file 2 label (optional)> ... File names (uri's) with newlines actually function "correctly" because the newlines get encoded as %0A. The label however is not encoded and it would be problematic to start encoding it at this point. Since the sidebar entries should be 1 line anyways, let's just use our existing eel_str_replace_substring() to change the newline to a space. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1502
d22207b4 -
Corey Berla authored
In some cases, an action that was disabled when opening the tab menu might stay disabled when you close the tab menu because of an early return. Make sure to reenable all of the actions when the tab menu is closed.
76898595 -
Sabri Ünal authored3bc0c67e
-
Corey Berla authored
The updated version of uncrustify didn't like this style, the new style doesn't look great either.
e9679b38 -
Jeremy Bicha authored
needed for adw_tab_bar_set_extra_drag_preload
9890e7ad -
Ondrej Holy authored
This reverts commit 23ae5387. This change was needed for split of desktop-related functionality, but it seems no more needed to me. Let's revert those changes to make the code a bit easier as a preparation for the next commits.
1c43d859 -
Ondrej Holy authored
This reverts commit 3014f694 and part of the commit a1751d3d. This extra handling was needed because `NautilusFreedesktopDBus` methods might be called before establishing its own D-Bus connection. The follow-up commit is going to use the already established connection from the `dbus_register` vfunc. It should be ensured that the `dbus_register` vfunc is called before the `window_added`, `window_removed`, or `startup` vfunc. Consequently, this extra handling is going to be redundant. Let's remove it as a preparation for the next commit.
bf615805 -
Ondrej Holy authored
The `org/freedesktop/FileManager1` interface is not currently exported from the `dbus_register` vfunc. This causes issues for projects (e.g. desktop-icons extension) that want to use all the Nautilus intefaces over the `org.gnome.Nautilus` connection. Let's use the already established connection and export the `FileManager1` interface from the `dbus_register` vfunc. https://bugzilla.redhat.com/show_bug.cgi?id=2150894
2293e813 -
Athul Iddya authored
Tooltips are not showing up for long file names that have Pango markup characters. This is happening because the cell widget label is set using `set_text`, but is retrieved in the `query-tooltip` signal handler using `get_label`. While `get_label` can return Pango markup, it is not guaranteed to return text with markup characters escaped. Avoid this problem by fetching the file name from label and setting tooltip using text.
60bd0613 -
António Fernandes authored
When an item is moved, we are still showing it in the old location as a regression caused by commit 510a4202 With the introduction of tree model, we maintain multiple list stores (one for each TreeListRow when the TreeListRow is a directory) and the item is associated with a directory store upon creation by checking nautilus_file_get_parent(). When removing an item, we again find the directory store to remove from, by checking directory_reverse_map for the parent file. But, when an item has been moved, the parent file is no longer the same as when it was added. This means we try to remove the file from the new parent instead of the old one. Fortunately we already have a solution for this from the old list view: NautilusFilesView.remove_file() gets passed the directory to remove the file from. Let's use it instead of the current parent. Heavily based on diagnosis and commit message from patch by Corey Berla Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2784
e13e08a9 -
António Fernandes authored
Toggling sort directories first in list view causes a crash. This is a regression in commit b9ac68eb gtk_sort_list_model_set_sorter() first unrefs the old sorter, then refs the new sorter. The crash happens because the new sorter is the new sorter. It gets destroyed by the unref, and therefore we crash when trying to ref a destroyed object. (It's arguably a GTK API bug too.) The solution (from our side) is for us to hold a temporary reference to keep the object alive.
43478c41 -
António Fernandes authored
They have been set on the cell in commit 728bec15 But they don't work because the focus is never in the cell. So, set them in the view instead, and trigger them in the capture phase to prevent GtkListBase's cursor movement shortcuts taking priority.
58384883 -
António Fernandes authored
When using the collapse shortcut (Left arrow in LTR locales), if the row is already collapsed, we want to move to the parent row. Currently we select the parent but don't move focus. Fix that.
49cc0743 -
António Fernandes authored
A property binding is unfit for our use case because directory loading is async, so the expander arrow is temporarily hidden, which is wrong and looks like a glitch. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2791
e9cfb16d -
António Fernandes authored
No functional change in this commit, but this is going to make it possible for each view to pick the areas which trigger the hover timeout, to be done in the next commit.
bcbfcbf7 -
António Fernandes authored
GtkTreeExpander includes a built-in "expand on drag hover" feature. But our own "open on drag hover" feature competes (and often wins) over it, making it hard to reliably expand rows on hover without opening the folder. So, separate the content and the expander. Trigger "expand on drag hover" only if over the expander, and "open on drag hover" only if over the rest.
9c93e2fd -
Corey Berla authored21c79c06
-
Corey Berla authored
We have a docs options, but we are generating the docs regardless of if it is set. This was a regression in d47403bc. `gi_docgen.found()` is redundant because when 'docs' is set to true gi_docgen is a requirement.
dac56fca -
Corey Berla authored33e93e8d
-
Corey Berla authored
As part of 42c195897c9e7cf9c80b01446466b4f535a354b2 uncrustify was being built from source to address a bug that is now fixed in the current release 0.75.
c8fe7974 -
Corey Berla authoredd06ca828
-
Corey Berla authored
We are generating the docs, so lets make them accessible online. See: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/941
e03fbb42 -
Corey Berla authored
* Update gpl to match project * Update authors to match about page (otherwise it says "unknown author") * Update website so it doesn't show a blank site * Add logo * Add dependencies
32b2a586 -
Corey Berla authoreda78f5861
-
Corey Berla authored
view-item holds a reference for the cell and the cell holds a ref to the item. In order to break this cycle, let's make item_ui a weak pointer in view-item. The cell will get freed by the list factory.
47b48cb8 -
Corey Berla authored
We are still leaking NautilusViewItem in several places. Essentially every NautilusViewItem (and thus every NautilusFile) ever created is leaked. In list-base, the queue in real_add_files is freed, but not the items themselves. Make sure to also free the results of g_list_model_get_item() and our macro listitem_get_view_item which now calls gtk_tree_list_row_get_item.
109cd125 -
Cheng-Chia Tseng authored
(cherry picked from commit 2c2a8394)
f2fa44cd -
Vasil Pupkin authored8beb3145
-
Ekaterine Papava authored0bda05bd
-
sunflowerskater authored
This change makes the rubberband to have rounded corners, making it consistent with other elements such as buttons and text entries, which also have rounded corners.
a126b550 -
Peter Eisenmann authored
Add a check to assert nautilus_files_view_drop_proxy_received_uris is not called with an empty source uri list. Make nautilus_dnd_perform_drop return whether the drop event was actually handled. Adjust callers accordingly. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2787
d084a720 -
Sabri Ünal authored2abc6eb3
-
Corey Berla authored
With non-local drops, when the value is initially NULL, we get warnings because of some of the checks done on a NULL value. This was a regression from 3d17ed25. Return action copy before any check dependent on a dropped value.
a72031b2 -
Ondrej Holy authored
The pages job is not running currently on master. This is because `only: refs: $CI_DEFAULT_BRANCH` is not supported (e.g. see https://gitlab.com/gitlab-org/gitlab/-/issues/29591). Let's fix that using one of the suggestions from that issue.
0bc1ad52 -
Ondrej Holy authored
The only/except keywords were deprecated in favor of rules. Let's replace them with rules.
29f4004f -
Ondrej Holy authored
The pages job is allowed on forks currently. It is not desired to run it there and it is going to fail there anyway. Let's explicitly disable this job on forks.
22d285e7 -
Ondrej Holy authored
The flatpak@aarch64 is not allowed on other branches than master but is allowed on forks. It would be nice to allow manual run in those cases to save resources, but to allow testing aarch64-specific fixes.
b9021e83 -
Ekaterine Papava authored29831e9b
-
Sabri Ünal authored3a37b843
-
Yosef Or Boczko authoredc29d4e18
-
Vasil Pupkin authored3d366527
-
Hugo Carvalho authored8ba536cb
-
Yosef Or Boczko authored062cc926
-
Yuri Chornoivan authoredc3921a1a
-
Aurimas Černius authoreda1ca3d9f
-
Asier Sarasua Garmendia authored6f2955d6
-
Aleksandr Melman authored9a477042
-
Kukuh Syafaat authored6fa4ba5c
-
Daniel Mustieles authored9fd2ad34
-
Fran Dieguez authoredfeb2ce00
-
Jordi Mas authored8a9de2bf
-
Jürgen Benvenuti authored902e1180
-
Sabri Ünal authored7b77f098
-
Ondrej Holy authored
The commit e2969a9c introduced an assertion statement to ensure that the `g_file_get_basename` returned non-NULL string. Unfortunately, the assertion has an inverted condition. This leads to crashes in the `get_unique_target_file` function for files that don't have the `edit-name` attribute set (i.e just a few GVfs backends). Let's fix the inverted condition. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2825
fcf8f9de -
Ondrej Holy authored
The flatpak jobs are broken currently, because the tracker-miners project fails to build due to missing upower-glib depenedency. It is used to tweak the behavior when running on battery. It used to be automatically disabled until the following MR: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/1121. I suppose it is safe to disable this functionality as our flatpak isn't meant for production. Let's explicitely disable that to fix our pipeline.
1569af12 -
Christopher Davis authored
List the form factors the app was designed for in the desktop file. This is so desktop environments like Phosh and Plasma Mobile can show or hide the app in the correct contexts.
ee558cb9 -
Christopher Davis authored
Declare what sort of hardware we support and the minimum display size Nautilus is usable on. This allows applications like Software to display hardware information or hide the app on incompatible hardware.
7b107580 -
Bogi Napoleon Wennerström authored
(cherry picked from commit c1ebea52)
900ece3e -
Quentin PAGÈS authoredc83a73fe
-
Ondrej Holy authored62729bae
-
Jeremy Bicha authoredcef88772
docs/reference/logo.svg
0 → 100644
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
po/fo.po
0 → 100644
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.