This fixes a regression that I introduced in 232c6134.

I got my browser stuck in a crash loop today while visiting a website
with a page title greater than ephy-embed.c's MAX_TITLE_LENGTH, the only
condition in which ephy_string_shorten() is ever used. Turns out this
commit is wrong: an ellipses is a multibyte character (three bytes in
UTF-8) and so we're writing past the end of the buffer when calling
strcat() here. Ooops.

Shame it took nearly four years to notice and correct this.

This reverts commit a748d58c.

This fixes #1760. This bug is specific to the gnome-42 branch. A similar
problem has been fixed in master via !1103.

This broke in 7d080a31. The callback here is not prepared for there to
be no async data, but the async data is only required when clearing a
single password, not when clearing all of them. The GTask is optional
even if there is async data. We're just going to need a bunch of
conditionals here.

Fixes #1773

Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1109>


(cherry picked from commit 1e2a5248)

https://bugzilla.redhat.com/show_bug.cgi?id=2088965

Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1115>


(cherry picked from commit adc02a8c)

This is part of a deal with Google to stop accounts.google.com from
discriminating against us. It's a very risky change, but we'll try it
for now and make a list of websites that it breaks.

Historical background, in order of recency:

https://bugs.webkit.org/show_bug.cgi?id=240041
https://bugs.webkit.org/show_bug.cgi?id=222978
https://bugs.webkit.org/show_bug.cgi?id=222039#c5
https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/595

Also, remove the web app branding, since the risk outweighs the reward
and I don't want a separate set of bugs in web app mode. I believe only
one website was using this:

https://bugzilla.gnome.org/show_bug.cgi?id=767123


(cherry picked from commit 65cbf8adcf3e75d2e47ae554fdc137bd026a8826)

This reverts commit 2f87340f

Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1166>

GNOME shell doesn't show the popup for low urgency notifications, leave
the default priority instead.

Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1179>


(cherry picked from commit 45efd6da)

This function is called to determine whether there exist Firefox
profiles or not, so it'd better not warn when there are none. This
condition can be detected via the NULL return value.


(cherry picked from commit ef34b5f5)

We are trying to use the index of the selected item to decide what
action to perform, but this doesn't work because not all items are
actually present in the combo box. E.g. if there is no Firefox profile,
it won't be present in the list. This causes the wrong codepath to be
selected. In this bug report, the user complains that it crashes due to
not finding any Firefox profiles when importing bookmarks from Chrome.

Fixes #1800


(cherry picked from commit a22f87c8)

When importing bookmarks, we have:

 (1) EphyWindow, transient parent of
 (2) GtkDialog to select where to import bookmarks from, transient
parent of
 (3) The native file chooser dialog (in case of GVDB or HTML import)

Sadly, opening a native dialog on a modal dialog hangs the application,
gtk#5011. To dodge this problem, we can close the second dialog
dialog when opening the third dialog, and make the EphyWindow the
transient parent of the third dialog. This is inconvenient because it
means you're all the way back to step one if you decide to cancel the
third dialog and want to go back to the second dialog, but it's better
than a hang.

Exporting bookmarks does not have this problem, because there we skip
step 2.

Importing passwords does not have this problem, because there we don't
have a native file chooser. (At least, I think so. Didn't test this
because I do not have Chrome installed.)


(cherry picked from commit 4b1e57d4)

The gnome-runtime-images have been recently migrated to Quay. This is already reflected in the template.

Please note this MR has been created semi-automatically. If it doesn't make sense, feel free to close it.

Upstream version 42.4

LP: #1984266