Skip to content
Commits on Source (45)
......@@ -52,7 +52,7 @@ stages:
# stable branch.
# Could probably also switch away from rawhide,
# to stable fedora branch as well.
FDO_DISTRIBUTION_TAG: '2022-03-29.0-main'
FDO_DISTRIBUTION_TAG: '2022-10-25.0-main'
FDO_DISTRIBUTION_VERSION: rawhide
#############################################
......@@ -130,6 +130,7 @@ build.container.fedora@x86_64:
alsa-lib-devel
nss-devel
gcr-devel
setxkbmap
FDO_DISTRIBUTION_EXEC: |-
git clone https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas.git && \
cd gsettings-desktop-schemas && \
......@@ -222,8 +223,8 @@ test:
- build
script:
- dnf -y install setxkbmap
- *environment_information
- *build_procedure
- *run_tests
- |
......@@ -313,9 +314,7 @@ flatpak:
OLD_APPID: "org.gnome.Settings"
APPID: "org.gnome.SettingsDevel"
BUNDLE: "org.gnome.SettingsDevel.flatpak"
MANIFEST_PATH: "org.gnome.Settings.json"
PATCHES: "build-aux/flatpak/*.patch"
PROJECT_FILE: "build-aux/flatpak/org.gnome.Settings.json"
MANIFEST_PATH: "build-aux/flatpak/org.gnome.Settings.json"
PROJECT_ID: "org.gnome.Settings"
PROJECT_NAME: "gnome-control-center.git"
RUNTIME_REPO: "https://sdk.gnome.org/gnome-nightly.flatpakrepo"
......@@ -323,10 +322,6 @@ flatpak:
script:
- echo "== Flatpak packaging =="
# Move needed files to the root folder
- cp ${PATCHES} . || true
- cp ${PROJECT_FILE} ${MANIFEST_PATH}
# Make it a develoment manifest
- sed -i -n "p; s/$PROJECT_NAME//p" ${MANIFEST_PATH}
- >
......@@ -344,7 +339,7 @@ flatpak:
- mv data/icons/hicolor/scalable/apps/$OLD_APPID.svg data/icons/hicolor/scalable/apps/$APPID.svg
- mv data/icons/hicolor/symbolic/apps/$OLD_APPID-symbolic.svg data/icons/hicolor/symbolic/apps/$APPID-symbolic.svg
- flatpak-builder --bundle-sources --repo=devel build ${MANIFEST_PATH}
- flatpak-builder --bundle-sources --disable-rofiles-fuse --repo=devel build ${MANIFEST_PATH}
- flatpak build-bundle devel ${BUNDLE} --runtime-repo=${RUNTIME_REPO} ${APPID}
cache:
......
......@@ -4,7 +4,7 @@ Not following the communication guidelines [1] will mean your issue or comment
will be removed. Read it carefully before submitting this issue.
[1] https://gitlab.gnome.org/GNOME/gnome-control-center/blob/main/docs/CONTRIBUTING.md#communication-guideline
[1] https://gitlab.gnome.org/GNOME/gnome-control-center/blob/main/docs/CONTRIBUTING.md#communication-guidelines
-->
......
......@@ -4,7 +4,7 @@ Not following the communication guidelines [1] will mean your issue or comment
will be removed. Read it carefully before submitting this issue.
[1] https://gitlab.gnome.org/GNOME/gnome-control-center/blob/main/docs/CONTRIBUTING.md#communication-guideline
[1] https://gitlab.gnome.org/GNOME/gnome-control-center/blob/main/docs/CONTRIBUTING.md#communication-guidelines
-->
......
================
Version 43.2
================
- Updated translations
About
- Update distro logo when dark-mode changes
Applications
- Don't recurse into symlinks when clearing cache
Cellular
- Avoid duplicated entries in SIM providers list
Color
- Fix crash when first device row is non-existent
Common
- Make list row switches work when annimations are OFF
Display
- Allow the Night Light error label to wrap for small screens
Mouse
- Fix activation of rows while navigating with keyboard
Network
- Fix crashes when EAP password is missing
- Fix wrong signal of SEA password visibility toggle
Notifications
- Sync lock screen notification setting string
Users
- Show a missing-avatar image when avatars cannot be loaded
================
Version 43.1
================
......
......@@ -66,7 +66,7 @@ size, disability, ethnicity, gender identity and expression, level of experience
nationality, personal appearance, race, religion, or sexual identity and
orientation.
### Communication Guideline
### Communication Guidelines
It is of ultimate importance to maintain a community in which everyone feels free to express
themselves, review, and comment on each others ideas, both technical and otherwise. Correspondingly,
......
project(
'gnome-control-center', 'c',
version : '43.1',
version : '43.2',
license : 'GPL2+',
meson_version : '>= 0.57.0'
)
......
......@@ -53,7 +53,7 @@ file_remove_thread_func (GTask *task,
GFile *file = source_object;
g_autofree gchar *path = g_file_get_path (file);
nftw (path, ftw_remove_cb, 20, FTW_DEPTH);
nftw (path, ftw_remove_cb, 20, FTW_PHYS | FTW_DEPTH);
if (g_task_set_return_on_cancel (task, FALSE))
g_task_return_boolean (task, TRUE);
......
......@@ -1642,7 +1642,8 @@ gcm_prefs_update_device_list_extra_entry (CcColorPanel *prefs)
gtk_widget_set_visible (prefs->box_devices, first_row != NULL);
/* if we have only one device expand it by default */
if (gtk_list_box_get_row_at_index (prefs->list_box, 1) == NULL)
if (first_row != NULL &&
gtk_list_box_get_row_at_index (prefs->list_box, 1) == NULL)
cc_color_device_set_expanded (CC_COLOR_DEVICE (first_row), TRUE);
}
......
......@@ -61,36 +61,6 @@ enum {
static GParamSpec *properties[N_PROPS];
static void
cc_list_row_activated_cb (CcListRow *self,
GtkListBoxRow *row)
{
g_assert (CC_IS_LIST_ROW (self));
if (!self->show_switch || row != GTK_LIST_BOX_ROW (self))
return;
cc_list_row_activate (self);
}
static void
cc_list_row_parent_changed_cb (CcListRow *self)
{
GtkWidget *parent;
g_assert (CC_IS_LIST_ROW (self));
parent = gtk_widget_get_parent (GTK_WIDGET (self));
if (!parent)
return;
g_return_if_fail (GTK_IS_LIST_BOX (parent));
g_signal_connect_object (parent, "row-activated",
G_CALLBACK (cc_list_row_activated_cb),
self, G_CONNECT_SWAPPED);
}
static void
cc_list_row_switch_active_cb (CcListRow *self)
{
......@@ -228,9 +198,6 @@ cc_list_row_init (CcListRow *self)
g_resources_register (cc_common_get_resource ());
gtk_widget_init_template (GTK_WIDGET (self));
g_signal_connect_object (self, "notify::parent",
G_CALLBACK (cc_list_row_parent_changed_cb),
self, G_CONNECT_SWAPPED);
}
void
......@@ -272,18 +239,6 @@ cc_list_row_get_active (CcListRow *self)
return self->switch_active;
}
void
cc_list_row_activate (CcListRow *self)
{
g_return_if_fail (CC_IS_LIST_ROW (self));
g_return_if_fail (self->show_switch);
self->switch_active = !self->switch_active;
g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_ACTIVE]);
gtk_widget_activate (GTK_WIDGET (self->enable_switch));
}
void
cc_list_row_set_secondary_label (CcListRow *self,
const gchar *label)
......
......@@ -37,7 +37,6 @@ void cc_list_row_set_show_arrow (CcListRow *self,
void cc_list_row_set_show_switch (CcListRow *self,
gboolean show_switch);
gboolean cc_list_row_get_active (CcListRow *self);
void cc_list_row_activate (CcListRow *self);
void cc_list_row_set_secondary_label (CcListRow *self,
const gchar *label);
void cc_list_row_set_secondary_markup (CcListRow *self,
......
......@@ -62,6 +62,7 @@
<object class="AdwActionRow" id="underscanning_row">
<property name="width_request">100</property>
<property name="title" translatable="yes">Adjust for TV</property>
<property name="activatable-widget">underscanning_switch</property>
<child>
<object class="GtkSwitch" id="underscanning_switch">
<property name="can_focus">False</property>
......
......@@ -27,10 +27,10 @@
</child>
<child>
<object class="GtkLabel">
<property name="halign">start</property>
<property name="margin-start">6</property>
<property name="hexpand">False</property>
<property name="label" translatable="yes">This could be the result of the graphics driver being used, or the desktop being used remotely</property>
<property name="wrap">True</property>
<property name="xalign">0.0</property>
</object>
</child>
</object>
......
......@@ -968,6 +968,8 @@ cc_info_overview_panel_class_init (CcInfoOverviewPanelClass *klass)
static void
cc_info_overview_panel_init (CcInfoOverviewPanel *self)
{
AdwStyleManager *style_manager;
gtk_widget_init_template (GTK_WIDGET (self));
g_resources_register (cc_info_overview_get_resource ());
......@@ -978,6 +980,8 @@ cc_info_overview_panel_init (CcInfoOverviewPanel *self)
info_overview_panel_setup_overview (self);
info_overview_panel_setup_virt (self);
style_manager = adw_style_manager_get_default ();
g_signal_connect_swapped (style_manager, "notify::dark", G_CALLBACK (setup_os_logo), self);
setup_os_logo (self);
}
......
......@@ -80,6 +80,7 @@
<object class="AdwActionRow" id="mouse_natural_scrolling_row">
<property name="title" translatable="yes" comments="Translators: This switch reverses the scrolling direction for mices. The term used comes from OS X so use the same translation if possible.">Natural Scrolling</property>
<property name="subtitle" translatable="yes">Scrolling moves the content, not the view.</property>
<property name="activatable-widget">mouse_natural_scrolling_switch</property>
<child>
<object class="GtkSwitch" id="mouse_natural_scrolling_switch">
<property name="valign">center</property>
......@@ -99,6 +100,7 @@
<child>
<object class="AdwActionRow" id="touchpad_toggle_row">
<property name="title" translatable="yes">Touchpad</property>
<property name="activatable-widget">touchpad_toggle_switch</property>
<child>
<object class="GtkSwitch" id="touchpad_toggle_switch">
<property name="valign">center</property>
......@@ -113,6 +115,7 @@
<object class="AdwActionRow" id="touchpad_natural_scrolling_row">
<property name="title" translatable="yes" comments="Translators: This switch reverses the scrolling direction for touchpads. The term used comes from OS X so use the same translation if possible. ">Natural Scrolling</property>
<property name="subtitle" translatable="yes">Scrolling moves the content, not the view.</property>
<property name="activatable-widget">touchpad_natural_scrolling_switch</property>
<child>
<object class="GtkSwitch" id="touchpad_natural_scrolling_switch">
<property name="valign">center</property>
......@@ -143,6 +146,7 @@
<object class="AdwActionRow" id="tap_to_click_row">
<property name="visible">False</property>
<property name="title" translatable="yes">Tap to Click</property>
<property name="activatable-widget">tap_to_click_switch</property>
<child>
<object class="GtkSwitch" id="tap_to_click_switch">
<property name="valign">center</property>
......@@ -157,6 +161,7 @@
<object class="AdwActionRow" id="two_finger_scrolling_row">
<property name="visible">False</property>
<property name="title" translatable="yes">Two-finger Scrolling</property>
<property name="activatable-widget">two_finger_scrolling_switch</property>
<child>
<object class="GtkSwitch" id="two_finger_scrolling_switch">
<property name="valign">center</property>
......@@ -172,6 +177,7 @@
<object class="AdwActionRow" id="edge_scrolling_row">
<property name="visible">False</property>
<property name="title" translatable="yes">Edge Scrolling</property>
<property name="activatable-widget">edge_scrolling_switch</property>
<child>
<object class="GtkSwitch" id="edge_scrolling_switch">
<property name="valign">center</property>
......
......@@ -200,7 +200,8 @@ static void
set_username (EAPMethod *method, const gchar *username)
{
EAPMethodSimple *self = EAP_METHOD_SIMPLE (method);
gtk_editable_set_text (GTK_EDITABLE (self->username_entry), username);
if (username)
gtk_editable_set_text (GTK_EDITABLE (self->username_entry), username);
}
static const gchar *
......@@ -214,7 +215,8 @@ static void
set_password (EAPMethod *method, const gchar *password)
{
EAPMethodSimple *self = EAP_METHOD_SIMPLE (method);
gtk_editable_set_text (GTK_EDITABLE (self->password_entry), password);
if (password)
gtk_editable_set_text (GTK_EDITABLE (self->password_entry), password);
}
static gboolean
......
......@@ -212,8 +212,8 @@ ws_sae_new (NMConnection *connection)
(HelperSecretFunc) nm_setting_wireless_security_get_psk);
}
g_signal_connect (self->show_password_check, "toggled",
G_CALLBACK (show_toggled_cb), self);
g_signal_connect_swapped (self->show_password_check, "toggled",
G_CALLBACK (show_toggled_cb), self);
/* Hide WPA/RSN for now since this can be autodetected by NM and the
* supplicant when connecting to the AP.
......
......@@ -14,7 +14,7 @@
</child>
<child>
<object class="CcListRow" id="lock_screen_row">
<property name="title" translatable="yes">_Lock Screen Notifications</property>
<property name="title" translatable="yes" comments="Translators: Whether to show notifications on the lock screen">_Lock Screen Notifications</property>
<property name="use-underline">True</property>
<property name="show-switch">True</property>
</object>
......
......@@ -66,7 +66,7 @@
<!-- Show Notifications row -->
<child>
<object class="AdwActionRow">
<property name="title" translatable="yes">Show _Notifications on Lock Screen</property>
<property name="title" translatable="yes" comments="Translators: Whether to show notifications on the lock screen">_Lock Screen Notifications</property>
<property name="activatable-widget">show_notifications_switch</property>
<property name="use-underline">true</property>
<child>
......
......@@ -216,8 +216,16 @@ create_face_widget (gpointer item,
AVATAR_CHOOSER_PIXEL_SIZE,
AVATAR_CHOOSER_PIXEL_SIZE,
NULL);
if (source_pixbuf == NULL)
return NULL;
if (source_pixbuf == NULL) {
image = gtk_image_new_from_icon_name ("image-missing");
gtk_image_set_pixel_size (GTK_IMAGE (image), AVATAR_CHOOSER_PIXEL_SIZE);
gtk_widget_show (image);
g_object_set_data_full (G_OBJECT (image),
"filename", g_steal_pointer (&image_path), g_free);
return image;
}
pixbuf = round_image (source_pixbuf);
image = gtk_image_new_from_pixbuf (pixbuf);
......
......@@ -281,7 +281,7 @@ wwan_data_update_apn_list_db (CcWwanData *self)
return;
if (!self->apn_list)
self->apn_list = g_list_store_new (CC_TYPE_WWAN_DATA_APN);
return;
if (!self->apn_db)
self->apn_db = nma_mobile_providers_database_new_sync (NULL, NULL, NULL, &error);
......