Commits on Source (28)
-
Jan Tojnar authored
In Nautilus 43, NautilusFile is no longer available (in the past, NautilusFileInfo was its alias). https://gitlab.gnome.org/GNOME/nautilus/-/commit/7e2605c681d065e6b0a3d779c30b892932597991 Similarly, the old names of interfaces that were renamed to use Interface suffix instead of Iface will not be available in Nautilus 43.
1691b2eb -
Bug-Debian: https://bugs.debian.org/957578 Forwarded: https://gitlab.gnome.org/GNOME/nautilus-python/-/merge_requests/7 Last-Update: 2020-05-11
dd7b0fe8 -
Jan Tojnar authored
nautilus-python-object.c: In function '__PyString_AsString': nautilus-python-object.c:45:12: warning: return discards 'const' qualifier from pointer target type [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wdiscarded-qualifiers-Wdiscarded-qualifiers8;;] 45 | return PyUnicode_AsUTF8(obj); | ^~~~~~~~~~~~~~~~~~~~~ nautilus-python.c: In function 'nautilus_python_check_all_directories': nautilus-python.c:249:12: warning: unused variable 'extensions_dir' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-variable-Wunused-variable8;;] 249 | gchar *extensions_dir = NULL; | ^~~~~~~~~~~~~~ nautilus-python.c: In function 'nautilus_module_initialize': nautilus-python.c:286:12: warning: unused variable 'user_extensions_dir' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-variable-Wunused-variable8;; ] 286 | gchar *user_extensions_dir; | ^~~~~~~~~~~~~~~~~~~ Co-Authored-By: Andreas Henriksson <andreas@fatal.se>
432a27f2 -
Jan Tojnar authoredba56875c
-
Jan Tojnar authored
That way, we can easily test them and apply other development tools.
6e48aa4e -
Jan Tojnar authored
In Python 3 urllib was split into multiple libraries, we do not need to support the Python 2 variant any longer.
38e7b3dd -
Jan Tojnar authored
It was not used for anything since https://gitlab.gnome.org/GNOME/nautilus-python/commit/d14849670f834e81f2061afc1e6879c6a166379b.
147985d4 -
Jan Tojnar authored
So that the style is consistent.
871eab8a -
Jan Tojnar authored
This will make it easier to port to Meson.
b093a1a1 -
Jan Tojnar authored2622a8d0
-
Jan Tojnar authored2775cf30
-
Jan Tojnar authored
Previously, they were just empty. Inspired by https://github.com/linuxmint/nemo-extensions/commit/67a5d42489a1ae1715f620f281b62b8cc444d2d0
132384b6 -
nautilus-python-object.c: Remove the extra reference on the PyObject file wrappers when adding them to the python list PyObjects start with a refcount of 1. Adding them to a PyList adds a second - which gets removes during the list's destruction. The additional ref was keeping its associated NautilusFile from ever being finalized. Steps to reproduce problem: 1) Install nautilus-python and some python MenuProvider extension. 2) Create a folder with a couple of image files inside. Be sure to allow thumbs to generate. 3) Enter the folder, select one or more files (so menus are generated). De-select and leave the folder (but do not close Nautilus). If you were to watch for the files' finalize to run, you'd notice it does not. 4) touch or otherwise modify one of the image files from a terminal 5) Re-enter the folder in nautilus. 6) See that loading status runs forever, modified file(s) never display. Note: even if you only modify one file, it could cause all of the files to fail to load, depending on their order during enumeration. When no more views are displaying a file, that file should be finalized. When it's not it ends up in an undefined state, as it has no monitors flag it as needing to be updated.
5049e1cb -
Jan Tojnar authored49e58693
-
Jan Tojnar authored
It is no longer supported.
d187ffb8 -
Jan Tojnar authored
Inspired by https://github.com/linuxmint/nemo-extensions/commit/f2a2ccf737ca1ca475d4c60d7bc00b190b83f7e0
561d3e4c -
PyObject_GetAttrString() returns new reference: https://docs.python.org/3/c-api/object.html#c.PyObject_GetAttrString
8908c474 -
Jan Tojnar authored
We install all other extensions from docs. Also correct the name.
908363cc -
Jan Tojnar authored
When overriding constructors, we need to call the parent constructor, otherwise GObject will not be properly initialized: >>> from importlib import import_module; ufia = import_module('examples.update-file-info-async') >>> ufia.UpdateFileInfoAsync() <update-file-info-async.UpdateFileInfoAsync object at 0x7f5fe326b5c0 (uninitialized at 0x(nil))> Furthermore, we can drop the constructors where we are not initializing any extra properties – then the constructor of the parent class (GObject will be called). We also need to ensure that GObject is the first parent class listed since otherwise, Python will try to call the constructor of the provider, which does not exist since it is an abstract class. We will keep it for TestExtension since it is the first example people reading the docs will see and hopefully that will reduce the amount of forgotten parent constructor calls. Noticed in https://github.com/linuxmint/nemo-extensions/commit/67a5d42489a1ae1715f620f281b62b8cc444d2d0
991754d6 -
Jan Tojnar authored
This should make it clearer what each function does, even though they are not checked. Also switched the tuples for proper lists since the API expects `GList`s.
3cfb7b8f -
Picked from https://github.com/linuxmint/nemo-extensions/commit/bd48a2da9012f81e0e3a1a09ca0069947a198de5 The `CONVERT_LIST` part is already merged as https://gitlab.gnome.org/GNOME/nautilus-python/-/merge_requests/8 The `Py_XDECREF(py_uri)` is not necessary since `N` arguments of `PyObject_CallMethod` do not increase reference count https://docs.python.org/3/c-api/arg.html#c.Py_BuildValue It would cause a crash and was reverted in https://github.com/linuxmint/nemo-extensions/commit/74b9e778cfa71daa619e16b3c4f945d2725d24e2.
183a6cd3 -
Jan Tojnar authored
Formatted with Prettier.
c4371453 -
Jan Tojnar authoredf664378d
-
Jan Tojnar authored
Mostly removed GTK-based API: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/927
fac72de5 -
Jan Tojnar authored
This replaces NautilusPropertyPageProvider from Nautilus-3.0.
652341e6 -
Jan Tojnar authoredec2e1e64
-
Jan Tojnar authored739405ee
-
Jeremy Bicha authored47fcdf32
ChangeLog
deleted
100644 → 0
INSTALL
deleted
100644 → 0
MAINTAINERS
0 → 100644
Makefile.am
deleted
100644 → 0
Makefile.in
deleted
100644 → 0
This diff is collapsed.
NEWS
deleted
100644 → 0
NEWS.md
0 → 100644
README
deleted
100644 → 0
README.md
0 → 100644
aclocal.m4
deleted
100644 → 0
This diff is collapsed.
compile
deleted
100755 → 0
config.guess
deleted
100755 → 0
This diff is collapsed.
config.h.in
deleted
100644 → 0
config.sub
deleted
100755 → 0
This diff is collapsed.
configure
deleted
100755 → 0
This diff is collapsed.
configure.ac
deleted
100644 → 0
depcomp
deleted
100755 → 0
This diff is collapsed.
docs/Makefile.am
deleted
100644 → 0
docs/Makefile.in
deleted
100644 → 0
This diff is collapsed.