Commits on Source (51)
-
Baurzhan Muftakhidinov authored6d5095e6
-
Sabri Ünal authored8ef9b0df
-
Carlos Garnacho authored
This list may be NULL, so protect against that happening. Fixes a number of runtime warnings on files that trigger the situation. Related: https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/233
f796a010 -
Carlos Garnacho authored
This is sadly something that may happen with btrfs subvolumes, so will be seen frequently in certain environments, or might cause the test suite to fail for no (unforeseen) reason. Convert this errno into a g_info() what will not be logged by default. Closes: https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/212
e096ef8b -
Sam Thursfield authored
tracker-extract: Protect against NULL GstTagList See merge request GNOME/tracker-miners!412
75a5e626 -
Sam Thursfield authored
libtracker-miner: Avoid warning on EXDEV from fanotify_mark() Closes #212 See merge request GNOME/tracker-miners!413
f3ee0fb3 -
Carlos Garnacho authored
Instead of doing a specific run to get testing coverage, collect the information of all tests being done. Since some of these will check for different build options, it's not possible to do that from a single run. This way we will get accurate information for all code that is being actually exercised by the tests. In consequence, using eatmydata to run the tests is no longer ok, since there is the possibility that it also eats the coverage reports that are generated during test runs. Also, since running tracker-extract in tests with seccomp enabled prevents coverage information from being written for the metadata extractors, this also means we now disable the seccomp jail on all tests (as opposed to just the coverage target).
a083e96d -
Carlos Garnacho authored
It is no longer used, so we can stop fetching it.
4f9bab2e -
Carlos Garnacho authored
This stage runs the tests with seccomp enabled, thus still helping us catch disallowed syscalls that might sneak in dependencies as shipped by distros.
8682ff63 -
Carlos Garnacho authored
Traditionally, we've only rebuilt images on an as-needed basis, this however isn't most useful if we want to make CI able to track seccomp breaks in recent updates from distros. In order to help there, add the CI handling so we can trigger rebuild of testing containers on a scheduled job set up through the gitlab UI. This will help us catching newly introduced syscalls more proactively than now.
01aacd53 -
Carlos Garnacho authored
Instead of having to browse for it, expose the artifact in the gitlab MR UI.
b89131ac -
Sam Thursfield authored
ci: Collect coverage information from all tests See merge request GNOME/tracker-miners!411
16c5267e -
Carlos Garnacho authored
"Increase coverage with this weird trick", quit the main loop when SIGTERM is received, so that the writeback process can exit cleanly, and its coverage information ends up written. Should fix the 0% coverage seen in src/tracker-writeback altogether, since we do have functional tests that exercise this code.
9df66a5c -
Sam Thursfield authored
tracker-writeback: Exit cleanly on SIGTERM See merge request GNOME/tracker-miners!414
856ec287 -
Fabio Tomat authored03c320da
-
Nathan Teodosio authored
They cause builds to fail on Debian with "Disallowed syscall "get_mempolicy" caught in sandbox" Closes: https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/234
e298a2f0 -
Carlos Garnacho authored
Allow {get,set}_mempolicy syscalls Closes #234 See merge request GNOME/tracker-miners!415
d3f3c19b -
Alexander Shopov authorede7427b78
-
Alexander Shopov authoredd28552a7
-
Nart Tlisha authoredd85742c5
-
Sam Thursfield authored
gst_discoverer_stream_info_get_tags() now returns a `const GstTagList *`. No functional changes.
c8f60591 -
Carlos Garnacho authored
tracker-extract-gstreamer.c: Fix 'const' warning See merge request GNOME/tracker-miners!416
c0ef393e -
Carlos Garnacho authored
We already did let extractor modules provide a shutdown function, but this was never called. Add the missing code so that these shutdown functions are called during finalization.
f0005ae7 -
Carlos Garnacho authored
Given the limitations imposed by seccomp, extractor modules cannot (and should not) use the DBus connection or a readwrite connection where direct updates are possible. However these may want to inspect data existing in the filesystem miner database, provide this API so that extractor modules can obtain a readonly connection.
71f78103 -
Carlos Garnacho authored
As the seccomp jail works, extractor modules may have a hard time poking at DBus things, so we cannot obtain a dbus connection here. We can however open files readonly, so open the database this way. This will allow to use the miner database to resolve miscellaneous queries about files surrounding the file being extracted (e.g. cue sheets).
ef08b781 -
Carlos Garnacho authored
We used to iterate all files in the same folder than the audio file to look up CUE sheet files, but this may be overly expensive on very flat folder hierarchies where the audio file shares folder with other thousands of elements. Since we have this information indexed already, we can use a readonly connection to query for these CUE sheet files. It is very likely that these files are just indexed as nfo:FileDataObject, so we have to look up the file extension to determine cue files, since mimetype detection relies on the file extension too, the check is equivalent. And anyways, keep a fast-path lookup for CUE files that have the same filename but just different extension. Partly to keep tests happy, partly to also avoid possibly iterating over thousands of CUE files. Closes: https://gitlab.gnome.org/GNOME/tracker/-/issues/378
a3f81f4d -
Carlos Garnacho authored
It seems The gst_discoverer_info_get_stream_info() API call can return us a GstDiscovererContainerInfo or a plain GstDiscovererStreamInfo. Find out which is it, and use the right API to get its tags. Fixes the following warning seen with some files extracted by GStreamer: tracker-extract-3:25304): GStreamer-PBUtils-CRITICAL **: 13:44:06.792: gst_discoverer_container_info_get_tags: assertion 'GST_IS_DISCOVERER_CONTAINER_INFO (info)' failed Related: https://gitlab.gnome.org/GNOME/tracker/-/issues/378
91e340f9 -
Carlos Garnacho authored
This does currently have initialization issues in rawhide (through recursive gst_init calls), but also it does not provide anything that will be useful in metadata extraction. Simply avoid it entirely.
31a13e7b -
Carlos Garnacho authored
This is needed by SQLite on some circumstances, but these mostly apply to databases being opened with other users. This is something that happens on CI, but is not expected to happen in real circumstances. Anyhow, SQLite does not check for fchown return value, so just error out softly if that happens.
cdf28496 -
Sam Thursfield authored
Look up related CUE files through a SPARQL query Closes tracker#378 See merge request https://gitlab.gnome.org/GNOME/tracker-miners/-/merge_requests/417
8570ed7e -
Dušan Kazik authoreddddaa581
-
Sam Thursfield authored
This is preferred over epoll_create(), and is used in GLib 2.74 and later due to https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2868
8603d673 -
Sam Thursfield authored
This reverts commit 8603d673. The master branch is not protected to allow a specific release process, which means i can accidentally push to master instead of opening a PR.
7bfdce67 -
Sam Thursfield authored
This is preferred over epoll_create(), and is used in GLib 2.74 and later due to https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2868 https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/239
dd0bc714 -
Carlos Garnacho authored
seccomp: Allow epoll_create1() See merge request https://gitlab.gnome.org/GNOME/tracker-miners/-/merge_requests/419
ac81d2be -
Carlos Garnacho authored
Export the gcovr report using the cobertura format, that enables Gitlab to show coverage information inline in the diff view.
c4f761c3 -
Sam Thursfield authored
ci: Enable coverage integration in MR diff view See merge request https://gitlab.gnome.org/GNOME/tracker-miners/-/merge_requests/420
585e8d65 -
Мирослав Николић authored6f2655bc
-
Carlos Garnacho authored
This is not being freed on TrackerMinerFs finalization.
78d5894a -
Carlos Garnacho authored
If we fail to create a monitor with errors other than EOVERFLOW, we would leak the data we just created to attempt to create the FANotify directory monitor.
15e612b0 -
Carlos Garnacho authored
Fix issues reported by valgrind See merge request https://gitlab.gnome.org/GNOME/tracker-miners/-/merge_requests/421
84b71d43 -
Carlos Garnacho authored6f800404
-
Nart Tlisha authoredc2eb8325
-
Nathan Follens authored964cc517
-
Fred authored1c23de88
-
Carlos Garnacho authored
Fix flatpak command See merge request https://gitlab.gnome.org/GNOME/tracker-miners/-/merge_requests/418
d296a869 -
Carlos Garnacho authored
This internal library depends on generated headers from libtracker-miners-common, add a dependency on it so meson/ninja get the order right. Closes: https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/246
9f563746 -
Sam Thursfield authored
libtracker-miner: Add missing libtracker-miners-common dep Closes #246 See merge request https://gitlab.gnome.org/GNOME/tracker-miners/-/merge_requests/422
dfe18355 -
Nart Tlisha authored7d4aa115
-
Carlos Garnacho authoreddca2d2ff
-
Jeremy Bicha authoreda56d14c4
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.