Automeris naranja authored Feb 14, 2023 and Niels De Graef committed Feb 19, 2023

This change shorten tooltip texts (using header capitalization),
following the tooltip examples provided by HIG.

Tooltip examples can be seen at:
https://developer.gnome.org/hig/patterns/feedback/tooltips.html

Automeris naranja authored Feb 14, 2023 and Niels De Graef committed Feb 19, 2023

Acc. HIG, "if the text field performs an action, they [placeholders] can be phrased as an instruction".

https://developer.gnome.org/hig/patterns/controls/text-fields.html

GtkDialog is going to be deprecated in the next version of GTK, so stop
using it upfront to avoid the deprecation warnings.

Rather than awkwardly shoehorning an `AdwAvatar` into a button, let's be
a bit more helpful and just overlay 2 buttons, one for editing and one
for deleting the avatar.

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/217
Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/26

This fixes an issue where removing an avatar from a contact would not
update the UI, as the current pixbuf would still keep being displayed.

Apparently `AdwApplication` automatically loads `style.css` from the
GResource base path [1]. By default, that base path in a `GApplication`
is the app ID (with some slight post processing). Let's use that so we
can remove our custom CSS loading code.

Basically, this commit moves `/org/gnome/Contacts/ui/style.css` to
`/org/gnome/Contacts/style.css` to automatically use that behavior.

[1]: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/styles-and-appearance.html#custom-styles

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/252

We weren't sending out a property notification for `is-empty` when the
underlying `Folks.PostalAddress` changed, which meant that editing a
contact would only allows for a single address.

Also add a test to make sure we're not regressing on this.

Rather than building a big if-else block in the `Contacts.Io` namespace,
it's much more interesting to move the GVariant serialization into the
`Contacts.Chunk` objects themselves. That allows us to keep the
serialization logic for a specific field in one place and makes sure we
don't forget about any properties as they're not part of that big
if-else block that checks on property name.

This commit also make sure a lot of the functionality here is now unit
tested, to make sure we're not accidentally regressing.

So when we import vCard files that have those properites, we don't
forget about them.

Add a few more vCard tests to make sure we're not regressing on our
vCard import feature.

One of the design desicions at the time was to make the
`Contacts.Io.Parser` take a `GLib.InputStream` so we can make it
agnostic of what kind of input was given. We can now use this to make
the vCard tests a bit simpler in general by using a constant string
inside the test file rather than having to deal with environment
variables to pass on a path.

These days meson complains a bit if you `meson $BUILDDIR` instead of
`meson setup $BUILDDIR`, so update our instructions. While we're at it,
adjust them to use the meson-specific wrappers for building and
installing, rather than using ninja directly

Automeris naranja authored Feb 25, 2023 and Niels De Graef committed Mar 04, 2023

The Main Menu is also known as the primary menu, so it doesn't
make sense to set the secondary menu as primary.


(cherry picked from commit b3f2b50883198df47c7a2a0e98ecfb9ff3c775f0)

Vala doesn't really do basic compiler checks on calls to
`g_return_*_if_fail()` in Vala code, leading to errors in clang. In
these cases, it should be fine to do a hard `assert` instead, since
those functions not working would probably lead to a segfault later on
anyway.

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/275