Commits on Source (49)
-
Ondrej Holy authored322afdb7
-
Martin authoredf3e53ade
-
Boyuan Yang authoredeb07ad75
-
Nathan Follens authored1ace3d53
-
Trần Ngọc Quân authoredf21aab4e
-
Ondrej Holy authored
Currently, the `Nautilus: "@name" parameter unexpected at this location` warning is shown during build. This is caused by the extra newline character in the documentation comment for the `nautilus_column_new` function. Let's remove this extra newline character to get rid of that warning.
fbbfa749 -
Ondrej Holy authored
Currently, the `ignoring return value of ‘g_string_free_and_steal’ declared with attribute ‘warn_unused_result’` warning is shown during build. This is because the `str` struct member is used instead of a return value from the `g_string_free` function. Let's update the code to use the return value in order to avoid this warning.
06a838b0 -
Ondrej Holy authored
The `‘action’ may be used uninitialized` warning is shown during build currently. It can really happen that uninitialized value is used when dropping something else then `GDK_TYPE_FILE_LIST` on the pathbar. Let's initialize the action to prevent this.
11c25a37 -
Ondrej Holy authored
The `‘action’ may be used uninitialized` warning is shown during build currently. It can really happen that uninitialized value is used when dropping something else then the `GDK_TYPE_FILE_LIST` and `G_TYPE_STRING` on the tab bar. Let's initialize the action to prevent this.
cb48f51b -
Ondrej Holy authored
The `Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"` warning is shown during build currently. This is caused by the usage of the `G_TYPE_INSTANCE_GET_PRIVATE` macro. However, the statement with this macro doesn't have any effect. This looks to be an oversight in the commit 335eabec. Let's drop the whole statement to get rid of this warning.
fa27862d -
Ondrej Holy authored
The `G_FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE` attribute doesn't have to be always set. The commit 0e597803 added the `G_FILE_ATTRIBUTE_STANDARD_FAST_CONTENT_TYPE` fallback inside the `NautilusFile` class, but not for other places. Let's fix this oversight. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2862
cbd4c1d9 -
Peter Eisenmann authored
gtk_window_get_focus can return NULL. Passing that directly into gtk_widget_is_ancestor throws a GLib warning, so handle it explicitly.
bb97b053 -
Peter Eisenmann authored
Changes in GTK (https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5442) require to use `gtk_switch_set_active` to flip a switch, otherwise it ends up in an inconsistent state. Fixes #2883
d7af6016 -
Peter Eisenmann authored
When copying these classes from GTK the translation domain was kept. This causes issues with translations in libadwaita widgets, so remove them. Fixes #2890
b2d1680f -
Alexander Shopov authored0e90eef4
-
Ondrej Holy authored
When the current location is marked as gone, Nautilus jumps to the first existing parent currently (except for non-native locations and mount roots). This is fine in most cases, but not for autofs locations as Nautilus jumps to parent everytime autofs mount timeouted. It would be better to stay in the same folder in this case. Let's try the current location first even if it is marked as gone to ensure that. It would be perhaps even better to prevent autofs locations somehow from timeouting at all, or avoid immediate remounting at least, but those solutions don't look easy to implement. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1514
b0e28bc1 -
António Fernandes authored
Otherwise, due to some modular arithmetic artifacts, there is an unsightly 1px transparent line between the picture and its css border. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2779
baab8d3a -
Alexander Shopov authoredae2946a8
-
Alexander Shopov authored9ddf0c19
-
Gary Li authored
Nautilus fails critical assertions if the user opens then closes a new window in rapid succession in a large folder. This is because the GSource created by nautilus_path_bar_set_templates_menu to bind menu model to popover is not removed even if the pathbar has already been finalized by the user closing the window. Keep track of the source id and remove source if the pathbar is being disposed of. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2867
c10be39c -
Alexander Shopov authoredf0e2a316
-
Sayan Bhattacharjee authored
In the sidebar, when dragging to re-order bookmarks, other bookmarked folders are automatically opening while hovering over them as it happens during a drag-and-drop operation. This action should not be permitted because it is inconceivable to drag-and-drop a bookmark into another bookmark. Implement a check to prevent automatically navigating into the bookmarked folders if they are hovered on while dragging a bookmark with the intent to just re-order them. It achieves this behavior by not adding a navigation hover timeout if we are dragging a row (bookmark) in the sidebar. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2820
b44ebcfb -
Khalid Abu Shawarib authored
Open properties on the search directory crashes Nautilus. Exclude search, recent, and starred from opening current directory properties when no file is selected. Fixes #2903
f7ccb4e7 -
António Fernandes authored
nautilus-dropbox and probably other such extensions use emblems to indicate sync status. If these icons are installed as unthemed icons, then we don't display them at all. This is because the way we are checking that an icon exists ignores the unthemed icons completely, which is arguably a GTK bug (https://gitlab.gnome.org/GNOME/gtk/-/issues/5709) While the GTK inconsistency is not addressed, let's use a workaround to check more effectively whether an icon exits. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2789
032d7d00 -
Марко Костић authored4f04d447
-
Gary Li authored
Dead keys insert a provisional visual indication, which looks like a text insertion, but is actually signaled as `::delete-text`. Unlike regular emissions of `::delete-text`, here the start and end positions are exactly the same (so you know nothing is actually deleted). Nautilus deletes the neighbouring tag When a dead key is entered into the batch rename entry, it deletes the neighbouring tag. This occurs for just before, inside and just after the tag. This happens because our logic for knowing when to delete special text tags is assuming end_position > start_position, which is not the case with dead keys. Add conditions to ensure intersecting selections cannot be zero-length. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2821
ce367695 -
Ondrej Holy authored
Currently, it isn't possible to use Nautilus for the extraction of the ".zstd" and ".tar.zst" archives. However, it seems that this compression is supported by the libarchive library nowadays. Let's add the `application/zstd` and `application/x-zstd-compressed-tar` mime-types to the list of supported. This will allow Nautilus to show the "Extract" and "Extract to..." actions. Also, bump the gnome-autoar dependency to the version with a corresponding change. Related: https://gitlab.gnome.org/GNOME/gnome-autoar/-/merge_requests/38 Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2860
92f088a3 -
Corey Berla authored
When using tree expanders, we have special cases for the backing uri. In GridView or ColumnView (without expanders), the backing uri is always the current view directory. With tree expanders, the backing uri is either the parent of the currently selected item, or the currently selected item (if it is an expanded directory). The same rules apply for multiple selection if there is a common parent. This was the case in 42, and the code was dropped in 6708861e, and as an oversight wasn't added back in when tree expanders were reintroduced. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2888
5144b43b -
Ondrej Holy authored
The pages job currently fails as the gnome-autoar dependency has been bumped without updating the image. However, the image is based on fedora:latest, which is still Fedora 37. So it doesn't include the latest gnome-autoar release anyways. Let's build the gnome-autoar master to fix the pipeline.
f0f8a11c -
Corey Berla authored
Similar to the last commit, we are using fedora:latest which doesn't know about a new dependency for libadwait (appstream). Install it manually after the dnf builddep.
a417d86b -
Corey Berla authored
Under certain circumstances (i.e. moving a file), we end up adding a non-existent file. This causes selection problems because the non-existent file is selected and then removed (causing another file to be selected). I'm not sure where the root cause is (between directory-async, directory notify, etc), but lets simply not add a file that we know shouldn't be added. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2828
9dd4a7f8 -
Corey Berla authored
There was an issue selecting using ctrl+select which was fixed in GTK. Our workaround is now making it break. Related: https://gitlab.gnome.org/GNOME/gtk/-/issues/5669
2e10ed11 -
Peter Eisenmann authored
Correctly handle the cancellation of a clipboard update by checking the return value of gdk_clipboard_read_value_finish() and returning early on cancellation. Fixes: #2868
f0f6c372 -
António Fernandes authored
This reverts commit 5f1680f9. It avoids a warning from g_date_time_new_from_iso8601() by pushing the code flow into another warning. A different solution is to follow.
ed2dbd69 -
António Fernandes authored
TrackerCursor returns NULL if it doesn't have information on the date. https://gnome.pages.gitlab.gnome.org/tracker/docs/developer/method.SparqlCursor.get_string.html We try to parse NULL as a date string. This is obviously wrong and gets us a precondition failure warning, as it should. So, if a string is NULL, just skip it. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2160
8ba2ebb4 -
António Fernandes authored
We've added them because the colors assigned by the default stylesheet were not adequate as per design review: d7b03656 Libadwaita 1.3 updated the stylesheet to use the design-choosen colors by default in views. [0] So, we should drop our overrides which are now unnecessary and even harmful (they may be out of sync). Also, require the stable release of the dependency, because 1.3.alpha didn't include [0]. [0] https://gitlab.gnome.org/GNOME/libadwaita/-/commit/fd83834f837baeb2650c75630de10ea5cdf032f2
b33bc642 -
Sam Hewitt authored
Grid view selections feature a border for increased visibility. Our list view lacks that because it adds custom padding, so we need to add it as a custom style. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2909
9a7e8832 -
Peter Eisenmann authored
Fixes #2767
4b646bcd -
Gary Li authored
Nautilus crashes under d45b820d when we open a second window and in both windows navigate to a common new location. This is caused by incorrect reference management in action_clone_window, where neither nautilus_window_slot_get_location nor nautilus_window_slot_get_pending_location increases the ref count of the GFile location. g_autoptr would cause location to be prematurely freed. Take the reference of location to allow g_autoptr to work correctly for all branches of action_clone_window. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2858
59cb3c45 -
Gary Li authored
Use g_set_object to simplify setter logic and avoid issues if current_location == location.
c02b2204 -
António Fernandes authoredad18733a
-
Sebastian Keller authored
Whenever g_time_zone_new_local() is called it has to check the file system for changes, because the system's time zone might have changed since the last call. This function was called multiple times for each file when generating the date string, which was causing some unnecessary overhead. This changes the code to re-use the local time zone from the first call.
a76d23f7 -
Corey Berla authored
We present a new toast every time the undo action changed which is confusing because you might have several undo toasts appearing over each other. To complicate matters, the previous undo toasts lie (undo'ing would actually undo a different action). There was a proposal in #2350 to batch undo toasts, but that's problematic because our undo manager is designed to undo exactly 1 action, we do not have an undo stack. The more straightforward solution seems to be simply dismissing the old undo toasts, when we popup a new undo toast. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2350
f763e1f9 -
Carlos Garnacho authored
At some point, the flatpak command line interface changed so it is not possible to add multiple values to a same key with a single --add-policy call. Doing this now results in a single value added, with the ';' escaped, this breaks Tracker portal access and results in Nautilus resorting to the built-in miner instance. It is however possible to call --add-policy multiple times to make a multi-valued key, this restores the intended behavior and provides access to the two tracker:FileSystem and tracker:Documents graphs. Adapt the flatpak manifest to do this. Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2838
9ff35c64 -
Peter Eisenmann authored
In 098f6a43 the style was changed from dim-label to caption. For consistency with list-view columns and to have less visual noise, add the dim-label style class back. Fixes #2876
b6821915 -
Corey Berla authored
This reverts commit 9ecd422c. Its commit message is misleading. Maybe it had such a side effect, but the issue it fixed was actually a GTK bug which got fixed in the meantime: https://gitlab.gnome.org/GNOME/gtk/-/commit/8455b9ac74d5337429a1a14eb> Also, reverting it fixes a new bug: the first item is selected when the item which was selected has been deleted. Next item should be selected instead.
f1bb8e43 -
António Fernandes authored
It includes the GTK bugfix mentioned in 2e10ed11 As we have removed the workaround, we cannot accept a GTK version without that bugfix, because that would cause a regression. And we can't restore the workaround either, because it misbehaves when using the fixed GTK version. This leaves us with no other choice than requiring the fixed GTK version.
ee1d8237 -
António Fernandes authoreda3fda228
-
Jarred Wilson authored10c0abe1
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.