Phaedrus Leeds authored Mar 16, 2022 and Georges Basile Stavracas Neto committed Mar 18, 2022

Use g_object_ref_sink() for widgets since that is the right pattern for
GInitiallyUnowned objects, remove the corresponding
g_object_unref/g_clear_object in the free func, and make more use of
g_clear_object/g_clear_pointer.

For the screenshot portal this is a correctness fix since in that case
the g_clear_pointer() in screenshot_dialog_handle_close() was preventing
us from dropping the reference held on the dialog that we would
otherwise drop in screenshot_dialog_handle_free(). Otherwise these
changes should not introduce any functional difference.

This is to avoid a compiler warning on calls to
g_clear_pointer (&handle->dialog, gtk_window_destroy);

(cherry picked from commit 6d3c402a)

(cherry picked from commit 1ef7d46c)

In the SaveFile call, apps can pass all 3 options (current name, file,
and folder), but that's not really how the API is expected to be used.

When current file is passed, ignore current name and folder.

Fixes https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/issues/29

(cherry picked from commit 37b5359a)

(cherry picked from commit 406a3d76)

The theme is considered deprecated in favor of symbolic icons from
the regular theme.

When the session is closed, for example trying to share a screen in Chrome and closing
the web page while having the portal dialog still open, it will not take down the dialog
and instead it just gets hidden below Chrome's window.

It was unable to build gnome-desktop because libseccomp is a hard
dependency.

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/42

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/42

There's no need to duplicate the temporary URI string because
g_file_get_uri already returns a new copy for the caller to own.

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/42

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/42

Fallout from f323c6b1

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/42

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/46

Fallout from ab21bc9d and
7f635703

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/46

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/46

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/46

These should have been part of commit dc89f603.

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/46

We don't need any of them.

This commit adds a pair of windows to the preview, as per mockups.

https://gitlab.gnome.org/Teams/Design/os-mockups/-/blob/master/portals/portals.png

No functional changes.

GPtrArray is generally nicer to use, so let's use it.

This is not enough to fix [1], but it's a necessary step towards
that. This implicitly calls sync_state(), which we'll depend on
later.

[1] https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/issues/49

We need to wait for the full list of windows before attempting
to restore a previous window stream, otherwise we'll always fail.

Spin the mainloop until the list of windows is ready.

Fixes
https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/issues/49

Internally, whenever multiple callers call into sync_state(),
ShellIntrospection would perform as many separate operations
as the number of calls. This is not optimal.

Cancel ongoing calls to GetWindows() before calling it again.

The function parameter name does not match the .c counterpart. Fix
that.

The same code is repeated 3 times, so factor them out into a single
function. Future commits will increment this function to maybe
avoid the screenshot dialog altogether in some circumstances.

This will be used by the screenshot dialog to decide whether
or not to skip the dialog.

But only when the screenshot portal is version 3 or greater.
Before version 3, no portal-sided permissions were asked for
non-interactive screenshots, so we still have to show some
indication that the screen content was grabbed; but starting
from version 3, xdg-desktop-portal queries the user using the
access portal, so we don't have to do it again.

The same code is repeated 3 times, so factor them out into a single
function. Future commits will increment this function to maybe
avoid the screenshot dialog altogether in some circumstances.

xdg-desktop-portal 1.15.0 has an update to the Screenshot portal
D-Bus API for frontends, with a version bump. This new version
also contains a behavioural change where, if the frontend implements
version 2, it'll request the 'screenshot' permission. This allows
us to skip the permission dialog in this case.

Implement version 2 of org.freedesktop.portal.impl.Screenshot, and
skip the screenshot dialog when we know that a permission has been
granted, and when the screenshot is non-interactive.