We depend on libadwaita 1.2 now, so we no longer have to check whether
the property exists already.

Add updated screenshots for GNOME 43, hosted
on static.gnome.org. All people are fake,
with avatars generated with thispersondoesnotexist.com.

Related to https://gitlab.gnome.org/GNOME/Initiatives/-/issues/34

Alexander Mikhaylenko authored Aug 11, 2022 and Niels De Graef committed Aug 12, 2022

No other app has a margin there. Not even contacts on the other pane.

Alexander Mikhaylenko authored Aug 12, 2022 and Niels De Graef committed Aug 12, 2022

Don't go offscreen with too long names.

Alexander Mikhaylenko authored Aug 12, 2022 and Niels De Graef committed Aug 12, 2022

Multiple things here.

- The selection model state was mever synced back to the list
- The selected == null codepath didn't work
- unselect_all() does nothing with GtkSingleSelection
- gtk_list_box_unselect_all() does nothing with BROWSE selection mode

Fixes https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/262

Alexander Mikhaylenko authored Aug 12, 2022 and Niels De Graef committed Aug 12, 2022

Don't wait for the animation to end, just do it on visible-child changes
instead. Do it when folding while on the contact list pane as well.

Before this commit, the QueryFilter used a very naive implementation
where it would just re-filter all contacts if something change (like a
query string). This wasn't of course the most performant thing to do,
and after some investigation we found out that on each search bar
change, we were using quite some CPU.

This commit adds some optimizations by avoiding unnecessary refiltering
of contacts where possible. This shaves off quite a few percentages of
CPU usage when doing some searching in the side bar.

This allows us to split off the logic for filtering and sorting personas
from the generic `Utils` namespace, and allows us to expand on our
GListModel usage, which allows for some bigger cleanups planned ahead.

This allows us to split off the logic for filtering and sorting personas
from the generic `Utils` namespace, and allows us to expand on our
GListModel usage, which allows for some bigger cleanups planned ahead.

When starting the application (or when the user removes the input from
the search entry), the `QueryFilter` object we use to filter our
contacts will match any item. GTK allows us to specify this in the
`get_strictness()` method by returning `Gtk.FilterMatch.ALL`, which
is a performance improvement, as it doesn't have to iterate over all the
items in the list anymore.

This commit introduces a new class `Contacts.Chunk`. Just like libfolks,
we see a contact as a collection of data, or to word it differently: a
collection built up from "chunks" of information.

The net result of adding this concept adds quite a bit of lines of code,
but it does have some major benefits:

* Rather than stuffing new properties into yet another if-else spread
  out over multiple places in contacts-utils (and quite a bit of other
  files), we can create a new subclass of `Contacts.Chunk`
* This also goes for property-specific logic, which we can consolidate
  within their appropriate classes/files.
* All of our logic is now unit-testable

In the future, this would allow for more cleanups/features:

* We can put the serialization code for each property inside the
  `Contacts.Chunk`
* We can extend ContactSheet to show a vCard's information, before
  actually importing it into a Folks.Individual.
* We can write unit tests on the set of chunks, rather than regularly
  having to deal with yet another regression in e.g. the birthday
  editor.

When adding the feature to import and export contacts, we forgot to make
some strings translatable. Piotr found these, so let's mark them as such
(we're already in string freeze, but the alternative is that these won't
be translated anyway).

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/263

On a well configured system, this shouldn't happen since we expect
something like E-D-S to be running. Of course, distro bugs can happen,
and people can always screw up their system, so at least put a log
message asking them if something like E-D-S is running.

Related: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/179

Adrien Plazas authored Aug 18, 2022 and Niels De Graef committed Sep 03, 2022

This avoids the current contact to instantaneously disappear as the
transition is running or as we the user is swiping back, and close the
contact only once the contact pane is hidden.