Compare revisions

NetworkManager frequently refreshes the list of available access points.
For some reason this often ends up removing some or all access points
only to add them back in a later refresh later. With the exception of
the currently connected access point, which is never removed.

When all access points of a WirelessNetwork have been removed, it gets
destroyed by NMWirelessDeviceItem::_removeAccessPoint(). This however
does not happen for the currently connected network due to the always
present access point. If this network now happens to consist of multiple
access points, the "unused" NMAccessPoints will get removed and added
in these refreshes, without the WirelessNetwork getting destroyed.

Whenever such an unused access point is added, due to the use of signal
tracking this leaks the NMAccessPoint and SignalTracker until the
WirelessNetwork is destroyed.

However when the NMWirelessDeviceItem is destroyed, for example due to
suspending, it stops tracking access point changes, ensuring that the
condition for the WirelessNetwork being destroyed can not occur anymore.

Even with just two access points, such as can be found in 2.4GHz+5GHz
home routers this issue leaks hundreds of NMAccessPoints and
SignalTrackers per day. As well as a small number of WirelessNetworks
which are also kept alive by the SignalTrackers.

To fix this disconnect from the access point when it gets removed and
destroy all remaining networks when the NMWirelessDeviceItem is
destroyed.

(cherry picked from commit feb1c57d)

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2704>

(cherry picked from commit de08ec91)

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2704>

When the overview gets hidden during the startup animation, the callback
would still change the state to SHOWN, despite the overview not being
shown.

This can happen for example if a `monitors-changed` signal triggers a
relayout during startup.

See: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2514#note_1683525
(cherry picked from commit bb429737)

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2704>

Otherwise keyboard input would be going to whatever window was
preventing us from taking the grab while it is obscured by the overview.

(cherry picked from commit 56478f21)

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2704>

Update NEWS.