Commits on Source (54)
-
Andy Holmes authored
When a `PanelMenu.Button` is added to the `statusArea`, its menu is added to the `PopupMenuManager` if it has one at the time. If a menu is added later or a new one set, the new menu is never added. Move the call to `PopupMenuManager.addMenu()` from `_addToPanelBox()` to `_onMenuSet()`, which is called when the `PanelMenu.Button` is added and whenever it emits the `menu-set` signal. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2470>
990eb92b -
Jonas Ådahl authored
Use Meta.LaterType.BEFORE_REDRAW to queue setting the bind constraint offset in an idle callback. This is needed since the signals that trigger updating the offset may be emitted during allocation, at which point queuing new relayouts isn't ideal, since it could result in relayout cycles. In this case, we really do want to relayout as a side effect of another actors allocation, so make this explicit. This fixes a few warnings such as: The actor '<unnamed>[<StBoxLayout>:0x3138d70]' is currently inside an allocation cycle; calling clutter_actor_queue_relayout() is not recommended Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2476>
c080bc59 -
Carlos Garnacho authored
When updating the MRU sources if there was no prior MRU, we want to go with the unmodified list of sources in visibility order. However iterating over object properties happens in an undetermined order, so the initial MRU list ends up picking a value at random. In order to prefer the sources list in the same order than they appear in the menu if there was no prior MRU, order the keys when accessing it and building the initial list of sources. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5873 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2487>
13c9fd2a -
Bastien Nocera authored
In older versions of GNOME, when a menu was used for Bluetooth devices, we tried to avoid showing the Bluetooth menu to folks who didn't use Bluetooth. This kept causing problems as the menu would disappear if no devices were setup and the platform "airplane mode" removed the Bluetooth device from the USB bus, making it impossible to detect whether a Bluetooth device existed, compared to a user unplugging a removable Bluetooth device. Closes: #5749 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2488>
57aa91e2 -
Bastien Nocera authored
Now that we always show the Bluetooth switch when there's a Bluetooth adapter hiding somewhere, remove all the settings it used as storage. If the user wants to really really disable any Bluetooth adapters in their system, the gnome-bluetooth documentation explains how to do that irrespective of GNOME: https://gitlab.gnome.org/GNOME/gnome-bluetooth/#multiple-bluetooth-adapters Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2488>
e7cf6d34 -
Baurzhan Muftakhidinov authoreda040967d
-
Марко Костић authoredbd731213
-
Yosef Or Boczko authored4f6f86c3
-
Guillaume Bernard authored758539f5
-
Hugo Carvalho authored8abffd15
-
Kukuh Syafaat authoreda07a1858
-
Pawan Chitrakar authoreddf264bf3
-
Aleksandr Melman authored49ed7aef
-
Aurimas Černius authoredc465c70a
-
Anders Jonsson authoredfcebea8a
-
Jordi Mas authored15ee70d8
-
Danial Behzadi authored90166148
-
Dušan Kazik authored4816aa5c
-
Fabio Tomat authoreda3c84ca7
-
Olexander authored17b9b0b7
-
Nart Tlisha authoredc7cd51cb
-
Cheng-Chia Tseng authoredfd4bd24c
-
Alexander Shopov authoredf5c29de5
-
Florian Müllner authored
The description alone may not be descriptive enough, so include the origin (if available) to disambiguate the name. This is consistent with the Sound Settings panel. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5829 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2502>
0ce2bc34 -
Florian Müllner authored
PermissionStore's Set() method takes a complete permission table, so when setting an app's permission, we are implicitly removing all previously set entries for other apps. Switch to the SetPermission() method which sets the permission for a single app. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5937 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2504>
8590e335 -
Zurab Kargareteli authored82f13c3a
-
Jonas Ådahl authored
It was added relatively recently (1.5.24), so check if it exists first. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5958 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2511>
dfcab5a2 -
Alessandro Bono authored
Unused since 26235bbe. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2471>
b392e913 -
Alessandro Bono authored
There are cases where the animation time is set to 0 on purpose in order to not animate. When animations are disabled via /org/gnome/desktop/interface/enable-animations those animation times are increased from 0 to 1. This makes the "Caps lock is on." message appear unconditionally in the lockscreen for a brief moment. Select the minimum between the two values. So that an animation time 0 is preserved instead of being replaced by 1. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2471>
ee09c5c8 -
A S Alam authored5db9a7d2
-
Sam Hewitt authored
- remove the drop shadow - clean up mixin references Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2513>
c30aaf35 -
Florian Müllner authored
We currently special-case the no-window-title case when creating items, but not when accessing labels later, for example during allocation. The easiest option it to create the label unconditionally, so do that. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5851 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2483>
022c6496 -
Carlos Garnacho authored
Consider the existing input sources MRU only valid if it contained more than one element to pick from. Fixes the following situation with initial-setup sessions: - Initial setup Session starts, with several input sources already configured ("us" between them) - InputSourceManager initializes, only the default "us" keymap is available - MRU list is constructed, "us" is picked - InputSourceManager catches up with session configuration, the other extra sources are added - MRU list is reconstructed, "us" is already the most recent - Session ends up with "us" picked, regardless of its position in the list, and no MRU existing prior to startup If we consider the intermediate single-element MRU list invalid, it is still possible to pick the best default source between all the configured ones (the one that was put first in the list, basically), after initialization is complete. But also, it is unnecessary to have if there is a single source to pick from. After the sources list has two elements or more, the MRU list will become effective and preserved during changes to the available sources. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5873 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2495>
9c262ad7 -
Florian Müllner authored
We currently don't update running apps when the set of installed apps changes. However we should, as the change could mean that - the app got uninstalled, and the running app should become window-backed - a newly installed app got launched before the app cache was updated, and we replace the window-backed fallback with the proper app https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5664 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2480>
d7dc50da -
Carlos Garnacho authored
Move inline anonymous function to be its own. This method will become asynchronous in following commits. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2508>
766314ac -
Carlos Garnacho authored
When propagating keys from the OSK, we usually feed these directly to the IBusInputContext and let the IM handle the effects of this virtual key event (which may also include feeding a key event back to us). But these functions may also return a FALSE value if the key was "let through" by the IM, which means the ball is in our yard again, and we are responsible of letting this event get to its destination. If that happens, just fall through, so the string is committed to the client as an UTF-8 string, or propagated through keyboard events. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5930 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2508>
76090c14 -
Sam Hewitt authored
- add an entire flat style to button drawing function - clean up the icon button css in quick settings - adjust padding in QS sliders - fixes #5918 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2510>
ea7b29e0 -
Florian Müllner authored
GDBusProxy transparently handles the remote object appearing and vanishing. It is therefore not an error if the service is not running at the time the proxy is initialized, so we proceed and try to read the list of profiles which is null in that case, resulting in (harmless but annoying) warnings. Avoid this by only reading the initial list of profiles if the service has a name owner. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5992 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2518>
cbbc066d -
Sebastian Keller authored
Gstreamer 1.20.4 includes a fix in the videoconvert element that makes it no longer necessary to always copy buffers in pipewiresrc to have smooth recordings. This change now skips those otherwise unnecessary copies when using a new enough videoconvert. Related: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2928 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2503>
d7b44319 -
Kosmas Martakidis authoredc750a3d1
-
Fabio Tomat authoredebc5319a
-
Carlos Garnacho authored
Since this is an async operation, we may want to let some things happen after the engine is changed due to completion being enabled/disabled. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2512>
290dd38a -
Carlos Garnacho authored
This may need to be synchronized in other places, so keep the rectangle around. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2512>
ff09c4ef -
Carlos Garnacho authored
Make the input method synchronize its state after the engine changes resulting from completion being toggled. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2512>
b2f22661 -
Carlos Garnacho authored
Besides user interaction, there's two users of IBusManager.setEngine(): - The code that toggles all IBus engines off on entries with PASSWORD purpose. - The code that toggles completion support on OSK presence. These are currently pretty oblivious to each other. Make this interaction more resilient by making all external IBusManager changes more cautious about directly changing the engine, and revoke properly the completion mode if it needs be (e.g. changing to a non-XKB engine). But another notable change is that ibus-typing-booster is now preferred always, over PASSWORD purpose hints. This is done to avoid possible doubled attempts to change the current engine (and ensuing IBusInputContext confusion). Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2512>
12032dcc -
Carlos Garnacho authored
The IBusInputContext currently seems to be a bit sloppy wrt propagating the current state to engines after those are changed, this results in engines possibly ending with purpose/hint/etc that do not actually correspond to the current state. Ensure this state is cleared on unfocus of our IBusInputContext, so that the next time the input method receives an input focus, the new state makes it all the way to the currently active engine. Fixes situations in the GDM/lock screen password entry that IBus would miss the PASSWORD hint set on the StEntry, and let passwords be fed to engines. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5966 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2512>
ecc3cf8a -
Nart Tlisha authored762be990
-
Nathan Follens authored698588d8
-
Marco Trevisan authored
gnome-shell-portal-helper was failing with: (gnome-shell-portal-helper:646052): Gjs-CRITICAL **: 12:24:30.852: JS ERROR: ImportError: No JS module 'fileUtils' found in search path @resource:///org/gnome/shell/portalHelper/main.js:13:30 @<main>:1:14 Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6020 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2524>
a25d0f6d -
Florian Müllner authored
We use filesink, not filesrc ... https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5710 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2519>
cff56d4b -
Florian Müllner authored
Some gstreamer plugins require a connection to the display server, so if we end up initializing gstreamer before we are ourselves fully initialized, we may end up with a locked compositor. Avoid this by moving the runtime recorder check into the screencast D-Bus service, so that all gstreamer calls happen out of process. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5710 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2519>
f266c2ca -
Florian Müllner authored
Instead of assuming that gst-plugins-good has been compiled with all the plugins we need enabled, explicitly check for the ones we use. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5710 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2519>
3cdcd075 -
Florian Müllner authored
Update NEWS.
8b00255c -
Simon McVittie authoredff64359f