Milan Crha · Philip Withnall · Milan Crha · Philip Withnall · Milan Crha · Pablo Correa Gómez
--- a/NEWS
+++ b/NEWS
+Version 43.4
+~~~~~~~~~~~~
+Released: 2023-02-10
+
+This is a stable release with the following changes:
+ * Stop cancelled search in appstream data early
+ * Lookup for appstream-provided icons in more directories
+
 Version 43.3
 ~~~~~~~~~~~~
 Released: 2023-01-06

--- a/data/metainfo/org.gnome.Software.metainfo.xml.in
+++ b/data/metainfo/org.gnome.Software.metainfo.xml.in
@@ -66,6 +66,15 @@
   Validate with `appstreamcli validate *.metainfo.xml`
  -->
  <releases>
+    <release date="2023-02-10" version="43.4" type="stable">
+      <description>
+        <p>This is a stable release with the following changes:</p>
+        <ul>
+          <li>Stop cancelled search in appstream data early</li>
+          <li>Lookup for appstream-provided icons in more directories</li>
+        </ul>
+      </description>
+    </release>
    <release date="2023-01-06" version="43.3" type="stable">
      <description>
        <p>This is a stable release with the following changes:</p>

--- a/lib/gs-appstream.c
+++ b/lib/gs-appstream.c
@@ -203,7 +203,10 @@ gs_appstream_build_icon_prefix (XbNode *component)
 	/* check format */
 	path = g_strsplit (tmp, "/", -1);
 	npath = g_strv_length (path);
-	if (npath < 3 || !(g_strcmp0 (path[npath-2], "xmls") == 0 || g_strcmp0 (path[npath-2], "yaml") == 0))
+	if (npath < 3 ||
+	    !(g_strcmp0 (path[npath-2], "xmls") == 0 ||
+	      g_strcmp0 (path[npath-2], "yaml") == 0 ||
+	      g_strcmp0 (path[npath-2], "xml") == 0))
 		return NULL;

 	/* fix the new path */
@@ -1530,6 +1533,9 @@ gs_appstream_do_search (GsPlugin *plugin,
 				}
 			}
 		}
+
+		if (g_cancellable_set_error_if_cancelled (cancellable, error))
+			return FALSE;
 	}
 	g_debug ("search took %fms", g_timer_elapsed (timer, NULL) * 1000);
 	return TRUE;

--- a/lib/gs-plugin.c
+++ b/lib/gs-plugin.c
@@ -1092,7 +1092,7 @@ gs_plugin_reload_cb (gpointer user_data)
 void
 gs_plugin_reload (GsPlugin *plugin)
 {
-	g_debug ("emitting ::reload in idle");
+	g_debug ("emitting %s::reload in idle", gs_plugin_get_name (plugin));
 	g_idle_add_full (G_PRIORITY_DEFAULT_IDLE, gs_plugin_reload_cb,
 			 weak_ref_new (plugin), (GDestroyNotify) weak_ref_free);
 }

--- a/meson.build
+++ b/meson.build
 project('gnome-software', 'c',
-  version : '43.3',
+  version : '43.4',
  license : 'GPL-2.0+',
  default_options : ['warning_level=1', 'c_std=c11'],
  meson_version : '>=0.58.0'